Skip to content

chore: address commit comments for commit 8b0b780 #8072

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Sep 14, 2025
Merged

chore: address commit comments for commit 8b0b780 #8072

merged 6 commits into from
Sep 14, 2025

Conversation

rajanarahul93
Copy link
Contributor

Resolves #8027.

Description

What is the purpose of this pull request?

This pull request:

  • addresses a maintainer's comment by adding a missing newline for code style consistency in a TypeScript definition file.

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@stdlib-bot stdlib-bot added Needs Review A pull request which needs code review. Good First PR A pull request resolving a Good First Issue. labels Sep 14, 2025
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Sep 14, 2025 •
edited
Loading

Coverage Report

Package Statements Branches Functions Lines
number/float32/base $\color{green}195/195$
$\color{green}+100.00\%$ 		$\color{green}1/1$
$\color{green}+100.00\%$ 		$\color{green}0/0$
$\color{green}+100.00\%$ 		$\color{green}195/195$
$\color{green}+100.00\%$
number/float32/base/to-binary-string $\color{green}415/415$
$\color{green}+100.00\%$ 		$\color{green}38/38$
$\color{green}+100.00\%$ 		$\color{green}3/3$
$\color{green}+100.00\%$ 		$\color{green}415/415$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

@kgryte
Copy link
Member

kgryte commented Sep 14, 2025

@rajanarahul93 You didn't actually address the commit comments. Please review the comments in 8b0b780.

@kgryte kgryte added Needs Changes Pull request which needs changes before being merged. and removed Needs Review A pull request which needs code review. labels Sep 14, 2025
kgryte
kgryte approved these changes Sep 14, 2025
View reviewed changes
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rajanarahul93 Please pay attention to the changes that I made which actually resolve the commit comments. Simply adding random blank lines is not what we want.

@kgryte kgryte removed the Needs Changes Pull request which needs changes before being merged. label Sep 14, 2025
@kgryte kgryte merged commit 22abc2e into stdlib-js:develop Sep 14, 2025
10 checks passed
@rajanarahul93
Copy link
Contributor Author

@kgryte Thank you for merging the PR. I’ll make sure not to repeat this mistake next time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kgryte kgryte kgryte approved these changes

Assignees
No one assigned
Labels
Good First PR A pull request resolving a Good First Issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Address commit comments (commit 8b0b780)
3 participants
@rajanarahul93 @stdlib-bot @kgryte